Merge pull request #223 from fabulous-dev/remove-extension-attributes

Remove unnecessary [<Extension>] attributes

Directory.Packages.props

@@ -5,7 +5,7 @@
   <ItemGroup>
     <PackageVersion Include="Fabulous" Version="3.0.0-pre1" />
     <PackageVersion Include="FsCheck.NUnit" Version="2.16.4" />
-    <PackageVersion Include="FSharp.Core" Version="8.0.100" />
+    <PackageVersion Include="FSharp.Core" Version="8.0.200" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
     <PackageVersion Include="NUnit" Version="3.13.3" />

extensions/Fabulous.Avalonia.ColorPicker/ColorPicker.fs

@@ -32,7 +32,6 @@ module ColorPickerBuilders =
         static member ColorPicker(color: Color, fn: Color -> 'msg) =
             WidgetBuilder<'msg, IFabColorPicker>(ColorPicker.WidgetKey, ColorView.ColorChanged.WithValue(ValueEventData.create color fn))
 
-[<Extension>]
 type ColorPickerModifiers =
     /// <summary>Link a ViewRef to access the direct ColorPicker control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.ColorPicker/ColorPreviewer.fs

@@ -36,7 +36,6 @@ module ColorPreviewerBuilders =
         static member ColorPreviewer(fn: ColorChangedEventArgs -> 'msg) =
             WidgetBuilder<'msg, IFabColorPreviewer>(ColorPreviewer.WidgetKey, ColorPreviewer.ColorChanged.WithValue(fn))
 
-[<Extension>]
 type ColorPreviewerModifiers =
     /// <summary>Link a ViewRef to access the direct ColorSlider control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.ColorPicker/ColorSlider.fs

@@ -59,7 +59,6 @@ module ColorSliderBuilders =
         static member ColorSlider(color: Color, fn: Color -> 'msg) =
             WidgetBuilder<'msg, IFabColorSlider>(ColorSlider.WidgetKey, ColorSlider.ColorChanged.WithValue(ValueEventData.create color fn))
 
-[<Extension>]
 type ColorSliderModifiers =
     /// <summary>Link a ViewRef to access the direct ColorSlider control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.ColorPicker/ColorSpectrum.fs

@@ -69,7 +69,6 @@ module ColorSpectrumBuilders =
         static member ColorSpectrum(color: Color, fn: Color -> 'msg) =
             WidgetBuilder<'msg, IFabColorSpectrum>(ColorSpectrum.WidgetKey, ColorSpectrum.ColorChanged.WithValue(ValueEventData.create color fn))
 
-[<Extension>]
 type ColorSpectrumModifiers =
     /// <summary>Link a ViewRef to access the direct ColorSpectrum control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.ColorPicker/ColorView.fs

@@ -113,7 +113,6 @@ module ColorViewBuilders =
         static member ColorView(color: Color, fn: Color -> 'msg) =
             WidgetBuilder<'msg, IFabColorView>(ColorView.WidgetKey, ColorView.ColorChanged.WithValue(ValueEventData.create color fn))
 
-[<Extension>]
 type ColorViewModifiers =
     /// <summary>Link a ViewRef to access the direct ColorView control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.DataGrid/DataGrid.fs

@@ -207,7 +207,6 @@ module DataGridBuilders =
         static member CustomDataGrid(items: #IEnumerable) =
             CollectionBuilder<'msg, IFabDataGrid, #IFabDataGridColumn>(DataGrid.WidgetKey, DataGrid.Columns, DataGrid.Items.WithValue(items))
 
-[<Extension>]
 type DataGridModifiers =
     /// <summary>Link a ViewRef to access the direct DataGrid control instance.</summary>
     /// <param name="this">Current widget.</param>
@@ -601,7 +600,6 @@ type DataGridModifiers =
     static member inline onUnloadingRowDetails(this: WidgetBuilder<'msg, IFabDataGrid>, fn: DataGridRowDetailsEventArgs -> 'msg) =
         this.AddScalar(DataGrid.UnloadingRowDetails.WithValue(fn))
 
-[<Extension>]
 type DataGridExtraModifiers =
     /// <summary>Sets the HorizontalGridLinesBrush property.</summary>
     /// <param name="this">Current widget.</param>
@@ -645,7 +643,6 @@ type DataGridExtraModifiers =
     static member inline verticalGridLinesBrush(this: WidgetBuilder<'msg, IFabDataGrid>, value: string) =
         DataGridModifiers.verticalGridLinesBrush(this, View.SolidColorBrush(Color.Parse(value)))
 
-[<Extension>]
 type DataGridCollectionBuilderExtensions =
     [<Extension>]
     static member inline Yield<'msg, 'marker, 'itemType when 'itemType :> IFabDataGridColumn>

extensions/Fabulous.Avalonia.DataGrid/DataGridCheckBoxColumn.fs

@@ -67,7 +67,6 @@ module DataGridCheckBoxColumnBuilders =
                 )
             )
 
-[<Extension>]
 type DataGridCheckBoxColumnModifiers =
     /// <summary>Link a ViewRef to access the direct DataGridCheckBoxColumn control instance.</summary>
     /// <param name="this">Current widget.</param>

extensions/Fabulous.Avalonia.DataGrid/DataGridTextColumn.fs

@@ -87,7 +87,6 @@ module DataGridTextColumnBuilders =
                 )
             )
 
-[<Extension>]
 type DataGridTextColumnModifiers =
     /// <summary>Link a ViewRef to access the direct DataGridTextColumn control instance.</summary>
     /// <param name="this">Current widget.</param>
@@ -145,7 +144,6 @@ type DataGridTextColumnModifiers =
     static member inline foreground(this: WidgetBuilder<'msg, IFabDataGridTextColumn>, value: WidgetBuilder<'msg, #IFabBrush>) =
         this.AddWidget(DataGridTextColumn.ForegroundWidget.WithValue(value.Compile()))
 
-[<Extension>]
 type DataGridTextColumnExtraModifiers =
     /// <summary>Set the Foreground property.</summary>
     /// <param name="this">Current widget.</param>

extensions/Fabulous.Avalonia.DataGrid/_DataGridColumn.fs

@@ -25,7 +25,6 @@ module DataGridColumn =
     let IsVisible =
         Attributes.defineAvaloniaPropertyWithEquality DataGridColumn.IsVisibleProperty
 
-[<Extension>]
 type DataGridColumnModifiers =
 
     /// <summary>Sets the CellTheme property.</summary>

extensions/Fabulous.Avalonia.ItemsRepeater/ItemsRepeater.fs

@@ -50,7 +50,6 @@ module ItemsRepeaterBuilders =
             ) =
             WidgetHelpers.buildItems<'msg, IFabItemsRepeater, 'itemData, 'itemMarker> ItemsRepeater.WidgetKey ItemsRepeater.ItemsSource items template
 
-[<Extension>]
 type ItemsRepeaterModifiers =
     /// <summary>Link a ViewRef to access the direct ItemsRepeater control instance</summary>
     /// <param name="this">Current widget</param>

extensions/Fabulous.Avalonia.TreeDataGrid/TreeDataGrid.fs

@@ -60,7 +60,6 @@ module TreeDataGridBuilders =
         static member TreeDataGrid(source: #ITreeDataGridSource, rows: IRows) =
             WidgetBuilder<'msg, IFabTreeDataGrid>(TreeDataGrid.WidgetKey, TreeDataGrid.Source.WithValue(source), TreeDataGrid.Rows.WithValue(rows))
 
-[<Extension>]
 type TreeDataGridModifiers =
     /// <summary>Link a ViewRef to access the direct TreeDataGrid control instance</summary>
     /// <param name="this">Current widget</param>

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.100",
+    "version": "8.0.200",
     "rollForward": "latestMajor",
     "allowPrerelease": false
   }

samples/Gallery/Common.fs

@@ -102,7 +102,6 @@ module HamburgerMenuExtBuilders =
         static member inline HamburgerMenu() =
             CollectionBuilder<'msg, IFabHamburgerMenu, IFabTabItem>(HamburgerMenuExt.WidgetKey, ItemsControl.Items)
 
-[<Extension>]
 type HamburgerMenuModifiers =
     [<Extension>]
     static member inline reference(this: WidgetBuilder<'msg, IFabHamburgerMenu>, value: ViewRef<HamburgerMenu>) =

samples/Gallery/Pages/OpenGLPage.fs

@@ -402,7 +402,6 @@ module OpenGLWidgetBuilders =
         static member inline OpenGlPageControl<'msg>(yaw: float, pitch: float, roll: float, disco: float) =
             WidgetBuilder<'msg, IFabOpenGlPageControl>(OpenGlPageControl.WidgetKey, OpenGlPageControl.Data.WithValue(struct (yaw, pitch, roll, disco)))
 
-[<Extension>]
 type OpenGLWidgetModifiers =
     [<Extension>]
     static member inline reference(this: WidgetBuilder<'msg, IFabOpenGlPageControl>, value: ViewRef<OpenGlPageControl>) =

samples/RenderDemo.Android/RenderDemo.Android.fsproj

@@ -16,8 +16,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.3.1.3" />
-    <PackageReference Include="Xamarin.AndroidX.Lifecycle.ViewModel" Version="2.3.1.3" />
+<!--    <PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.3.1.3" />-->
+<!--    <PackageReference Include="Xamarin.AndroidX.Lifecycle.ViewModel" Version="2.3.1.3" />-->
     <PackageReference Include="Avalonia.Android" />
     <ProjectReference Include="..\RenderDemo\RenderDemo.fsproj" />
 

samples/RenderDemo/Animations/SlidingAnimation.fs

@@ -78,7 +78,6 @@ module ViewExtensions =
             | ValueNone -> ()
             | ValueSome v -> SetBottom(target, v))
 
-[<Extension>]
 type AnimatedControlModifiers =
     [<Extension>]
     static member inline slideLeft(this: WidgetBuilder<'msg, #IFabControl>, value: float) =

samples/RenderDemo/Widgets.fs

@@ -32,7 +32,6 @@ module HamburgerMenuBuilders =
             CollectionBuilder<'msg, IFabHamburgerMenu, IFabTabItem>(HamburgerMenu.WidgetKey, ItemsControl.Items)
 
 
-[<Extension>]
 type HamburgerMenuModifiers =
     [<Extension>]
     static member inline reference(this: WidgetBuilder<'msg, IFabHamburgerMenu>, value: ViewRef<HamburgerMenu>) =

src/Fabulous.Avalonia/Application.fs

@@ -233,7 +233,6 @@ module ApplicationBuilders =
         static member inline SingleViewApplication<'msg, 'childMarker>() =
             SingleChildBuilder<'msg, IFabApplication, 'childMarker>(Application.WidgetKey, Application.MainView)
 
-[<Extension>]
 type ApplicationModifiers =
     /// <summary>Sets the application name.</summary>
     /// <param name="this">Current widget.</param>
@@ -320,7 +319,6 @@ type ApplicationModifiers =
     static member inline reference(this: WidgetBuilder<'msg, IFabApplication>, value: ViewRef<FabApplication>) =
         this.AddScalar(ViewRefAttributes.ViewRef.WithValue(value.Unbox))
 
-[<Extension>]
 type ApplicationYieldExtensions =
     [<Extension>]
     static member inline Yield(_: AttributeCollectionBuilder<'msg, #IFabApplication, IFabTrayIcon>, x: WidgetBuilder<'msg, #IFabTrayIcon>) : Content<'msg> =
@@ -334,7 +332,6 @@ type ApplicationYieldExtensions =
         ) : Content<'msg> =
         { Widgets = MutStackArray1.One(x.Compile()) }
 
-[<Extension>]
 type TrayIconAttachedModifiers =
     /// <summary>Sets the tray icons for the application.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Collections/Carousel.fs

@@ -75,7 +75,6 @@ module CarouselBuilders =
             ) =
             WidgetHelpers.buildItems<'msg, IFabCarousel, 'itemData, 'itemMarker> Carousel.WidgetKey ItemsControl.ItemsSource items template
 
-[<Extension>]
 type CarouselModifiers =
 
     /// <summary>Sets the PageTransition property.</summary>

src/Fabulous.Avalonia/Views/Collections/ListBox.fs

@@ -36,7 +36,6 @@ module ListBoxBuilders =
         static member ListBox() =
             CollectionBuilder<'msg, IFabListBox, IFabListBoxItem>(ListBox.WidgetKey, ItemsControl.Items)
 
-[<Extension>]
 type ListBoxModifiers =
     /// <summary>Sets the SelectionMode property.</summary>
     /// <param name="this">Current widget.</param>
@@ -59,7 +58,6 @@ type ListBoxModifiers =
     static member inline reference(this: WidgetBuilder<'msg, IFabListBox>, value: ViewRef<ListBox>) =
         this.AddScalar(ViewRefAttributes.ViewRef.WithValue(value.Unbox))
 
-[<Extension>]
 type ListBoxCollectionBuilderExtensions =
     [<Extension>]
     static member inline Yield<'msg, 'marker, 'itemType when 'itemType :> IFabListBoxItem>

src/Fabulous.Avalonia/Views/Collections/TabControl.fs

@@ -34,7 +34,6 @@ module TabControlBuilders =
         static member TabControl() =
             CollectionBuilder<'msg, IFabTabControl, IFabTabItem>(TabControl.WidgetKey, ItemsControl.Items, TabControl.TabStripPlacement.WithValue(Dock.Top))
 
-[<Extension>]
 type TabControlModifiers =
     /// <summary>Sets the HorizontalContentAlignment property.</summary>
     /// <param name="this">Current widget.</param>
@@ -57,7 +56,6 @@ type TabControlModifiers =
     static member inline reference(this: WidgetBuilder<'msg, IFabTabControl>, value: ViewRef<TabControl>) =
         this.AddScalar(ViewRefAttributes.ViewRef.WithValue(value.Unbox))
 
-[<Extension>]
 type TabControlExtraModifiers =
 
     /// <summary>Sets the HorizontalContentAlignment property to center.</summary>
@@ -78,7 +76,6 @@ type TabControlExtraModifiers =
     static member inline center(this: WidgetBuilder<'msg, #IFabTabControl>) =
         this.centerHorizontal().centerVertical()
 
-[<Extension>]
 type TabControlCollectionBuilderExtensions =
     [<Extension>]
     static member inline Yield<'msg, 'marker, 'itemType when 'itemType :> IFabTabItem>

src/Fabulous.Avalonia/Views/Collections/TreeView.fs

@@ -74,7 +74,6 @@ module TreeViewBuilders =
 
             WidgetBuilder<'msg, IFabTreeView>(TreeView.WidgetKey, TreeView.ItemsSource.WithValue(data))
 
-[<Extension>]
 type TreeViewModifiers =
     /// <summary>Link a ViewRef to access the direct TreeView control instance.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/AutoCompleteBox.fs

@@ -90,7 +90,6 @@ module AutoCompleteBoxBuilders =
                 AutoCompleteBox.TextChanged.WithValue(ValueEventData.create text fn)
             )
 
-[<Extension>]
 type AutoCompleteBoxModifiers =
     /// <summary>Sets the MinimumPrefixLength property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Border.fs

@@ -48,7 +48,6 @@ module BorderBuilders =
                 AttributesBundle(StackList.empty(), ValueSome [| Decorator.ChildWidget.WithValue(content.Compile()) |], ValueNone)
             )
 
-[<Extension>]
 type BorderModifiers =
     /// <summary>Sets the Background property.</summary>
     /// <param name="this">Current widget.</param>
@@ -106,7 +105,6 @@ type BorderModifiers =
     static member inline reference(this: WidgetBuilder<'msg, IFabBorder>, value: ViewRef<Border>) =
         this.AddScalar(ViewRefAttributes.ViewRef.WithValue(value.Unbox))
 
-[<Extension>]
 type BorderExtraModifiers =
     /// <summary>Sets the CornerRadius property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/Button.fs

@@ -51,7 +51,6 @@ module ButtonBuilders =
 
             )
 
-[<Extension>]
 type ButtonModifiers =
     /// <summary>Sets the ClickMode property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/ButtonSpinner.fs

@@ -29,7 +29,6 @@ module ButtonSpinnerBuilders =
         static member inline ButtonSpinner(text: string, fn: SpinEventArgs -> 'msg) =
             WidgetBuilder<'msg, IFabButtonSpinner>(ButtonSpinner.WidgetKey, ContentControl.ContentString.WithValue(text), Spinner.Spin.WithValue(fn))
 
-[<Extension>]
 type ButtonSpinnerModifiers =
 
     /// <summary>Sets the AllowSpin property.</summary>

src/Fabulous.Avalonia/Views/Controls/Buttons/DropDownButton.fs

@@ -39,7 +39,6 @@ module DropDownButtonBuilders =
                 )
             )
 
-[<Extension>]
 type DropDownButtonModifiers =
     /// <summary>Link a ViewRef to access the direct DropDownButton control instance.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/RadioButton.fs

@@ -74,7 +74,6 @@ module RadioButtonBuilders =
                 )
             )
 
-[<Extension>]
 type RadioButtonAttachedModifiers =
     /// <summary>Sets the GroupName property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/RepeatButton.fs

@@ -43,7 +43,6 @@ module RepeatButtonBuilders =
                 )
             )
 
-[<Extension>]
 type RepeatButtonModifiers =
     /// <summary>Sets the Delay property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/SplitButton.fs

@@ -43,7 +43,6 @@ module SplitButtonBuilders =
                 )
             )
 
-[<Extension>]
 type SplitButtonModifiers =
     /// <summary>Sets the Flyout property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/ToggleButton.fs

@@ -96,7 +96,6 @@ module ToggleButtonBuilders =
                 )
             )
 
-[<Extension>]
 type ToggleButtonModifiers =
     /// <summary>Link a ViewRef to access the direct ToggleButton control instance.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Buttons/ToggleSplitButton.fs

@@ -43,7 +43,6 @@ module ToggleSplitButtonBuilders =
                 )
             )
 
-[<Extension>]
 type ToggleSplitButtonModifiers =
     /// <summary>Link a ViewRef to access the direct ToggleSplitButton control instance.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Calendar.fs

@@ -74,7 +74,6 @@ module CalendarBuilders =
                 Calendar.SelectedDateChanged.WithValue(ValueEventData.create date fn)
             )
 
-[<Extension>]
 type CalendarModifiers =
     /// <summary>Sets the FirstDayOfWeek property.</summary>
     /// <param name="this">Current widget.</param>
@@ -153,7 +152,6 @@ type CalendarModifiers =
     static member inline reference(this: WidgetBuilder<'msg, IFabCalendar>, value: ViewRef<Calendar>) =
         this.AddScalar(ViewRefAttributes.ViewRef.WithValue(value.Unbox))
 
-[<Extension>]
 type CalendarExtraModifiers =
     /// <summary>Sets the HeaderBackground property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/CalendarDatePicker.fs

@@ -80,7 +80,6 @@ module CalendarDatePickerBuilders =
                 CalendarDatePicker.SelectedDateChanged.WithValue(ValueEventData.create date fn)
             )
 
-[<Extension>]
 type CalendarDatePickerModifiers =
     /// <summary>Sets the DisplayDate property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/CheckBox.fs

@@ -89,7 +89,6 @@ module CheckBoxBuilders =
                 )
             )
 
-[<Extension>]
 type CheckBoxModifiers =
     /// <summary>Link a ViewRef to access the direct CheckBox control instance.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/DataValidationErrors.fs

@@ -23,7 +23,6 @@ module DataValidationErrors =
     let HasErrors =
         Attributes.defineAvaloniaPropertyWithEquality DataValidationErrors.HasErrorsProperty
 
-[<Extension>]
 type DataValidationErrorsModifiers =
 
     /// <summary>Sets the HasErrors property.</summary>

src/Fabulous.Avalonia/Views/Controls/DatePicker.fs

@@ -48,7 +48,6 @@ module DatePickerBuilders =
         static member inline DatePicker(date: DateTimeOffset, fn: DateTimeOffset -> 'msg) =
             WidgetBuilder<'msg, IFabDatePicker>(DatePicker.WidgetKey, DatePicker.SelectedDateChanged.WithValue(ValueEventData.create date fn))
 
-[<Extension>]
 type DatePickerModifiers =
     /// <summary>Sets the DayVisible property.</summary>
     /// <param name="this">Current widget.</param>

src/Fabulous.Avalonia/Views/Controls/Documents/Bold.fs

@@ -23,7 +23,6 @@ module BoldBuilders =
         static member Bold(text: string) =
             View.Bold<'msg>() { View.Run<'msg>(text) }
 
-[<Extension>]
 type BoldModifiers =
     /// <summary>Link a ViewRef to access the direct Bold control instance.</summary>
     /// <param name="this">Current widget.</param>