Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add gamma distribution for roots #84

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

fabern
Copy link
Owner

@fabern fabern commented Apr 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.46%. Comparing base (a2d6a2f) to head (5786337).
Report is 9 commits behind head on develop.

Files Patch % Lines
src/func_discretize_soil_domain.jl 77.27% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage    66.26%   68.46%   +2.19%     
===========================================
  Files           18       18              
  Lines         2938     2867      -71     
===========================================
+ Hits          1947     1963      +16     
+ Misses         991      904      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…OS-latest

The test l345 and l346 of 03-regression-tests.jl work locally on bernstein
and in CI they pass with macOS-latest but not with other configurations.
They pass on Julia 1.12.0-DEV.280:
https://github.com/fabern/LWFBrook90.jl/actions/runs/8527005221/job/23357459163?pr=84

Therefore deactivate comparisons for both reference["StorageSWAT"] and reference["StorageWATER"].
@fabern fabern merged commit 38a2600 into develop Apr 4, 2024
5 checks passed
@fabern fabern deleted the feat-Gamma-distribution branch April 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants