Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of ExaPF #214

Closed
wants to merge 34 commits into from
Closed

Refactoring of ExaPF #214

wants to merge 34 commits into from

Conversation

frapac
Copy link
Member

@frapac frapac commented Jan 12, 2022

  • simplify drastically the code (would help future maintenance)
  • all functions are now implemented in src/Polar/functions.jl with the nonlinear basis introduced in https://arxiv.org/abs/1906.10652. This allows to streamline the evaluations of the callbacks with sparse linear algebra (mostly SpMV operations).
  • remove old code

A tutorial explaining the new implementation is coming.

@frapac
Copy link
Member Author

frapac commented Jan 12, 2022

This PR addresses #199 #85 #28

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #214 (88de7da) into develop (7bb6b4d) will decrease coverage by 7.92%.
The diff coverage is 90.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    78.60%   70.67%   -7.93%     
===========================================
  Files           37       27      -10     
  Lines         4039     2916    -1123     
===========================================
- Hits          3175     2061    -1114     
+ Misses         864      855       -9     
Impacted Files Coverage Δ
src/PowerSystem/PowerSystem.jl 97.91% <ø> (-0.30%) ⬇️
src/models.jl 100.00% <ø> (ø)
src/cuda_wrapper.jl 54.76% <54.76%> (ø)
src/autodiff.jl 68.96% <68.42%> (-7.46%) ⬇️
src/Polar/first_order.jl 87.03% <87.03%> (ø)
src/Polar/functions.jl 90.25% <90.25%> (ø)
src/LinearSolvers/LinearSolvers.jl 64.28% <100.00%> (-9.05%) ⬇️
src/Polar/legacy.jl 100.00% <100.00%> (ø)
src/Polar/newton.jl 100.00% <100.00%> (ø)
src/Polar/polar.jl 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb6b4d...88de7da. Read the comment docs.

@frapac frapac mentioned this pull request Jan 19, 2022
@frapac frapac closed this Jan 19, 2022
@frapac frapac deleted the fp/refactoring branch February 8, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants