Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on Binaryen and Wabt #141

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add documentation on Binaryen and Wabt #141

wants to merge 10 commits into from

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Dec 13, 2018 •
edited
Loading

@hugo-dc hugo-dc requested review from axic and lrettig December 13, 2018 23:30
@hugo-dc hugo-dc changed the title [wip] Add documentation on Binaryen and Wabt Add documentation on Binaryen and Wabt Dec 14, 2018
lrettig
lrettig reviewed Dec 14, 2018
View reviewed changes
Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugo-dc. A couple of high-level questions:

  1. Is this linked into the main README doc anywhere?
  2. Do you think it would be possible to add a little info at the beginning of this doc discussing the differences between binaryen and wabt? E.g., why do we need two of them? Is there some benefit to one over the other?

lrettig
lrettig requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small tweaks and some suggestions. Thanks Hugo!

wasm-engines.md Outdated Show resolved Hide resolved
wasm-engines.md Outdated Show resolved Hide resolved
wasm-engines.md Show resolved Hide resolved
wasm-engines.md Outdated Show resolved Hide resolved
wasm-engines.md Outdated Show resolved Hide resolved
@lrettig
Copy link
Member

lrettig commented Dec 14, 2018

Instructions on installing cmake are already here in the main doc - so maybe you could link to that part inline here!

@hugo-dc
Copy link
Member Author

hugo-dc commented Dec 15, 2018

@lrettig Thanks a lot for reviewing and improving the document!, I have made some changes according to your comments.

Lane Rettig added 3 commits December 15, 2018 15:05
lrettig
lrettig requested changes Dec 15, 2018
View reviewed changes
Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final clarification! Thanks

wasm-engines.md Show resolved Hide resolved
@lrettig lrettig mentioned this pull request Dec 27, 2018
Open
Some minor tweaks
4037c97 
Change capitalization, reformat slightly, add a link
@lrettig
Copy link
Member

lrettig commented Dec 27, 2018

Thanks @hugo-dc! Made a few final tweaks, have a look. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrettig lrettig lrettig approved these changes

@axic axic Awaiting requested review from axic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugo-dc @lrettig