Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(params) update docs for updating params #132

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Nov 1, 2023

closes ENG-2232

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for dancing-hummingbird-242a98 ready!

Name Link
🔨 Latest commit 7cf8227
🔍 Latest deploy log https://app.netlify.com/sites/dancing-hummingbird-242a98/deploys/6543986ac744cd0008cb26dc
😎 Deploy Preview https://deploy-preview-132--dancing-hummingbird-242a98.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linear bot commented Nov 1, 2023

ENG-2232 ParameterChangeProposal type possibly not working

Steps to reproduce

The community recently tried to raise the minimum deposit for governance proposals in order to prevent spam with the legacy - "/cosmos.params.v1beta1.ParameterChangeProposal" but it seems to not have worked even thought it passed

https://www.mintscan.io/evmos/proposals/225

Querying mainnet you can see it hasn't changed

evmosd q gov params \
--chain-id evmos_9001-2 \
--node https://g.w.lavanet.xyz:443/gateway/evmos/tendermint-rpc-http/60811f8677d569633ed1d41a1340c678
deposit_params:
  max_deposit_period: 259200s
  min_deposit:
  - amount: "3500000000000000000000"
    denom: aevmos
params:
  burn_proposal_deposit_prevote: false
  burn_vote_quorum: false
  burn_vote_veto: true
  max_deposit_period: 259200s
  min_deposit:
  - amount: "3500000000000000000000"
    denom: aevmos
  min_initial_deposit_ratio: "0.000000000000000000"
  quorum: "0.334000000000000000"
  threshold: "0.500000000000000000"
  veto_threshold: "0.334000000000000000"
  voting_period: 432000s
tally_params:
  quorum: "0.334000000000000000"
  threshold: "0.500000000000000000"
  veto_threshold: "0.334000000000000000"
voting_params:
  voting_period: 432000s

Expected Behaviour

  • Deprecate v1beta1 for the proposal.
  • Update documentation to reflect this change.

Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @GAtom22 🙏 Maybe it could be easier to just create one page outlining the proposal drafting process as a suggestion.

docs/protocol/modules/incentives.md Outdated Show resolved Hide resolved
@GAtom22 GAtom22 merged commit db5f7c3 into main Nov 2, 2023
6 checks passed
@GAtom22 GAtom22 deleted the GAtom22/update-params branch November 2, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants