Document that person image can show if JS is disabled #15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octopusinvitro
force-pushed
the
improve-img-tests
branch
from
f5d42a8 to
f9ce874
Compare
|
@octopusinvitro I'm a little confused by this one. The description says that it's about documenting things, but the only thing that has changed is tests. If the issue is that we need documentation, then this doesn't seem to be addressing that. If the issue is simply that we're missing tests, then I think the description should reflect that. |
|
@tmtmtmtm ah, sorry, is a dialectic thing. Tests are indeed documentation of how to use your code and how it works, the features it has, etc. That doesn't mean that there aren't other types of documentation as well. |
When JS is disabled, whatever is inside the noscript tag will be shown, in this case a person's image. Also, if a person doesn't have an image, a placeholder image will be shown. There where no tests to document that, so this commit adds them.
octopusinvitro
force-pushed
the
improve-img-tests
branch
from
f9ce874 to
ec235c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It improves the image tests in the term-table page tests for Northern Ireland, documenting the fact that a person with an image shows it both when JS is and is not disabled.
It also documents that when there is no image available for a person, a placeholder image will be shown.
Why was this needed?
Because there were no tests for it.
Relevant Issue(s)
None
Implementation notes
None
Screenshots
None
Notes to Reviewer
None
Notes to Merger
None