DEVPROD-7742 Fix current bodyclose lint issues #8601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evergreen retry |
Kimchelly
requested changes
Jan 9, 2025
| @@ -492,6 +492,7 @@ func (c *baseCommunicator) GetCedarConfig(ctx context.Context) (*apimodels.Cedar | |||
| if err != nil { | |||
| return nil, util.RespErrorf(resp, errors.Wrap(err, "getting the Cedar config").Error()) | |||
| } | |||
| defer resp.Body.Close() | |||
There was a problem hiding this comment.
This isn't necessary because utility.ReadJSON closes the body already (same with the others in this function). Since most of the methods share the same logic (make request, read the JSON body) is there a reason some of the methods have been changed to defer close the body and others have been changed to nolint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7742
Description
Before merging in the fix for our linter and adding stricter rules, I'm doing smaller PRs to fix the current mistakes that our linter should be catching.
This PR adds the bodyclose linter and fixes our current cases where we do not close the body. It does have some false positives with helper functions in particular (which usually it's good about but I had to add some nolint directives for them).
I also fixed it for the tests just to be semantic, but it probably isn't that important for them.
Testing
Running golangci-lint run in my terminal results in no more lint errors. This pulls from the .golangci.yml file's configuration (which our linter task should be doing.