Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker build failed #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: docker build failed #269

wants to merge 1 commit into from

Conversation

maakinoh
Copy link
Contributor

@maakinoh maakinoh commented Dec 24, 2024 •
edited
Loading

The docker build has been failing recently.
Probably due to several PRs (#242 #250,and #265) - some of which I created myself, to my shame.

  • The Clitoolbox was still referenced at some places
  • Husky.Net wasn't disabled in docker properly.
  • We've updated to dotnet 9 too early, so I rolled back to version 8, since we don't target version 9 yet.
    Correct me if I'm wrong here @Metawolve, but AFAIK, you can only compile a dotnet project with the same version of dotnet installed, right?
  • Transitive dependency caused a compile error and I had to upgrade it (no breaking changes from what I'm seeing).

@maakinoh
fix: docker build failed because of a wrong dotnet version and husky.
001d14d 
Husky was disabled in docker and the dotnet version was downgraded again.
@maakinoh maakinoh requested a review from Metawolve December 24, 2024 00:20
Metawolve
Metawolve approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Metawolve Metawolve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metawolve Metawolve Metawolve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maakinoh @Metawolve