-
Notifications
You must be signed in to change notification settings - Fork 20.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/devp2p/internal/ethtest: using slices.SortFunc to simplify the code #31012
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
This type can probably be deleted, and its use replaced by |
If this kind of code style change is worthwhile, would you reconsider #30957? |
In general, we do not care too much about improving small details like this. If the code works, we think it's fine. And it will be rewritten or deleted at some point anyway. I suggested to remove type |
Thanks for your reply. I am happy to make such changes. The code has been optimized using |
Signed-off-by: dashangcun <[email protected]>
Using slices.SortFunc to simplify the code.