Rust: don't leak fd on load_trusted_setup_file() error (#402)

ethereum · Mar 4, 2024 · 8758b27 · 8758b27
1 parent 2ab0c21
commit 8758b27
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/bindings/rust/src/bindings/mod.rs b/bindings/rust/src/bindings/mod.rs
@@ -193,6 +193,8 @@ impl KZGSettings {
         let mut kzg_settings = MaybeUninit::<KZGSettings>::uninit();
         let result = unsafe {
             let res = load_trusted_setup_file(kzg_settings.as_mut_ptr(), file_ptr);
+            let _unchecked_close_result = libc::fclose(file_ptr);
+
             if let C_KZG_RET::C_KZG_OK = res {
                 Ok(kzg_settings.assume_init())
             } else {
@@ -202,9 +204,6 @@ impl KZGSettings {
             }
         };
 
-        // We don't really care if this fails.
-        let _unchecked_close_result = unsafe { libc::fclose(file_ptr) };
-
         result
     }
 }