-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disambiguate and ensure consistency of proposeBlockV3
/getBlockRewards
consensus block value
#481
base: master
Are you sure you want to change the base?
Conversation
… consensus block value
I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not. |
part of proposer reward is explicitly the reward from inclusion of slashings, im not sure how we make it clearer unless we link to the spec... |
Agreed. Do we want to be explicit to the point saying |
I think that stating explicitly that the rewards value is the sum of values the proposer rewards from attestations, sync committees and slashings included in the proposal would provide clarity on exactly what is and is not included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implements the agreed-upon outcome of the discussion in that call.