Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate github pages deployment workflow to CircleCI #507

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

janjakubnanista
Copy link

@janjakubnanista janjakubnanista commented Jan 15, 2025

Description

Migrates the GH Pages deployment workflow to CircleCI.

I also added mise as a dependency manager. mise is being used in the optimism monorepo and provides a great way of managing tooling required for development.

It is an add-on, it does not break or affect any existing development flows, just provides a convenient way of setting up your development environment (as well as the CI environment).

  • Adds the new publish workflow
    • The workflow is split into build-book and publish-book jobs to further restrict the access to the circleci-repo-specs security context
      • build-book does not need any secrets and will build the artifacts only
      • publish-book receives the artifacts and publishes them to GH Pages
  • Reused the build-book job for specs-check workflow instead of running just build as a step
  • Added a missing packageManager field to package.json

Tests

The workflow has been tested on a separate test branch, see here

Additional context

Metadata

@janjakubnanista janjakubnanista changed the title Jan/circleci chore: Migrate github pages deployment workflow to CircleCI Jan 15, 2025
Copy link

@raffaele-oplabs raffaele-oplabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several fixes needed

@janjakubnanista janjakubnanista force-pushed the jan/circleci branch 4 times, most recently from 67259e7 to d3df3ee Compare January 15, 2025 22:02
@janjakubnanista janjakubnanista marked this pull request as ready for review January 15, 2025 22:02
@janjakubnanista janjakubnanista force-pushed the jan/circleci branch 2 times, most recently from a166c61 to e78d950 Compare January 17, 2025 16:21
@janjakubnanista
Copy link
Author

@raffaele-oplabs all fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants