-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate github pages deployment workflow to CircleCI #507
Open
janjakubnanista
wants to merge
14
commits into
main
Choose a base branch
from
jan/circleci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
force-pushed
the
jan/circleci
branch
from
January 15, 2025 17:06
b4e27da
to
eeea69f
Compare
janjakubnanista
changed the title
Jan/circleci
chore: Migrate github pages deployment workflow to CircleCI
Jan 15, 2025
raffaele-oplabs
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several fixes needed
janjakubnanista
force-pushed
the
jan/circleci
branch
4 times, most recently
from
January 15, 2025 22:02
67259e7
to
d3df3ee
Compare
janjakubnanista
requested review from
protolambda,
tynes,
ajsutton,
sebastianst and
mslipper
as code owners
January 15, 2025 22:02
janjakubnanista
force-pushed
the
jan/circleci
branch
2 times, most recently
from
January 17, 2025 16:21
a166c61
to
e78d950
Compare
@raffaele-oplabs all fixed! |
janjakubnanista
force-pushed
the
jan/circleci
branch
from
January 17, 2025 17:45
2cf1827
to
8d36043
Compare
janjakubnanista
force-pushed
the
jan/circleci
branch
from
January 17, 2025 21:34
8d36043
to
bac1b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the GH Pages deployment workflow to CircleCI.
I also added
mise
as a dependency manager.mise
is being used in the optimism monorepo and provides a great way of managing tooling required for development.It is an add-on, it does not break or affect any existing development flows, just provides a convenient way of setting up your development environment (as well as the CI environment).
publish
workflowbuild-book
andpublish-book
jobs to further restrict the access to thecircleci-repo-specs
security contextbuild-book
does not need any secrets and will build the artifacts onlypublish-book
receives the artifacts and publishes them to GH Pagesbuild-book
job forspecs-check
workflow instead of runningjust build
as a steppackageManager
field topackage.json
Tests
The workflow has been tested on a separate test branch, see here
Additional context
Metadata