Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ucash Token to Base #1012

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Add Ucash Token to Base #1012

merged 7 commits into from
Dec 17, 2024

Conversation

antron3000
Copy link
Contributor

Add UCASH token to BASE (orignally ERC20 on Ethereum)

https://www.coingecko.com/en/coins/ucash

@antron3000 antron3000 requested review from wbnns and a team as code owners November 29, 2024 17:09
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antron3000

Hello, your logo should be named logo.svg -- could you please update?

@antron3000
Copy link
Contributor Author

Changed logo name to logo.svg as requested

@wbnns
Copy link
Member

wbnns commented Dec 12, 2024

@an

Thanks for the update. I reran CI/CD and it is now also reporting that the decimals do not match between the two deployed versions:

error: UCASH on chain ethereum token 0x92e52a1A235d9A103D970901066CE910AAceFD37 has incorrect decimals

Please fix and let us know once updated.

@antron3000
Copy link
Contributor Author

The original token has 8 decimals. Fixed.

@antron3000
Copy link
Contributor Author

Is everything good to go @wbnns ?

@antron3000
Copy link
Contributor Author

Oh I see I need to deploy a new contract. doing now.

@antron3000
Copy link
Contributor Author

@wbnns Created new Token contract with 8 decimals. Should work now.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@antron3000 Thanks for the updates and for building on Base 🔵

@mergify mergify bot merged commit 5731343 into ethereum-optimism:master Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants