Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OL Token Mainnet #1005

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

mferranti
Copy link
Contributor

@mferranti mferranti requested review from wbnns and a team as code owners November 27, 2024 00:00
@wbnns wbnns self-assigned this Nov 29, 2024
@wbnns wbnns added the base label Nov 29, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mferranti

Hi there! Thanks for this PR! CI/CD is currently failing with the following issue:

error: OL on chain base token 0xEEB221A559F4aD1746F41460807E56d06D198A58 could not fetch l2Bridge or l1Token.
                    This token most likely needs nobridge or a bridge override set.
warning: OL on chain base-sepolia token 0x189e5d3e8b540a9f9a5a15BAd683d26fF87E3DdE has an overridden bridge

Could you please update? Once you've done so we'll rereview.

If you have further assistance or have questions, just let us know. 👍

@mferranti mferranti requested a review from wbnns November 29, 2024 20:01
@mferranti
Copy link
Contributor Author

@mferranti

Hi there! Thanks for this PR! CI/CD is currently failing with the following issue:

error: OL on chain base token 0xEEB221A559F4aD1746F41460807E56d06D198A58 could not fetch l2Bridge or l1Token.
                    This token most likely needs nobridge or a bridge override set.
warning: OL on chain base-sepolia token 0x189e5d3e8b540a9f9a5a15BAd683d26fF87E3DdE has an overridden bridge

Could you please update? Once you've done so we'll rereview.

If you have further assistance or have questions, just let us know. 👍

Thanks. I've added a bridge override.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mferranti Thanks for building on Base 🔵

Copy link
Contributor

mergify bot commented Dec 10, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #1005 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit c5b60fa into ethereum-optimism:master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants