Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename toU64(), toU256() for consistency with other functions #119

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Jan 13, 2025

Description

In slow & fast VM, there are toU64(v uint8) and toU256(v uint8). But in the Solidity implementation, there are functions with the same name, but their argument type is uint64. This makes developer confused and could make bugs. So renamed go functions to byteToU64() and byteToU256() to prevent confusion.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 84.39024% with 64 lines in your changes missing coverage. Please review.

Project coverage is 61.63%. Comparing base (3f1f5fc) to head (429e8cd).

Files with missing lines Patch % Lines
rvgo/slow/vm.go 82.17% 24 Missing and 12 partials ⚠️
rvgo/fast/vm.go 81.45% 24 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   61.63%   61.63%           
=======================================
  Files          27       27           
  Lines        4147     4147           
=======================================
  Hits         2556     2556           
  Misses       1444     1444           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ImTei ImTei added this pull request to the merge queue Jan 16, 2025
@ImTei ImTei removed this pull request from the merge queue due to a manual request Jan 16, 2025
@ImTei ImTei added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 8355a95 Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants