Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Treasure Mainnet and Update Treasure Topaz and Ruby Testnets #6332

Merged
merged 13 commits into from
Dec 9, 2024

Conversation

karelvuong
Copy link
Contributor

@karelvuong karelvuong commented Dec 4, 2024

Changelog

  • Remove Treasure Ruby (no longer running/supported)
  • Update Treasure Topaz details
  • Add Treasure Mainnet

Passes Checks

./gradlew run
image

npx prettier --write _data/*/*.json

Copy link

github-actions bot commented Dec 4, 2024

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

@karelvuong
Copy link
Contributor Author

Thanks @ligi, re-added and marked deprecated.

@karelvuong karelvuong requested a review from ligi December 6, 2024 17:32
Copy link

@Aholaone360 Aholaone360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gnote

Copy link
Contributor Author

@karelvuong karelvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ligi thanks for your help earlier. Just bumping in case you're able to take a quick look as have a few things blocked by this. 🙏

@ligi ligi merged commit f56c32c into ethereum-lists:master Dec 9, 2024
5 checks passed
Copy link

github-actions bot commented Dec 9, 2024

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants