Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add body-parser #161

Merged
merged 7 commits into from
Nov 15, 2024
Merged

docs: add body-parser #161

merged 7 commits into from
Nov 15, 2024

Conversation

Namchee
Copy link
Contributor

@Namchee Namchee commented Sep 28, 2024

Overview

Closes #160.

This pull request adds section for body-parser and its alternative (namely, milliparsec)

docs/modules/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but lets get at least one other opinion before we merge 👍

@TheThing
Copy link

Discussion on a discord server revealed that we should probably wait until default post limit is implemented into millisec. Don't want to give malicious people the ability to DDoS a server from this recommendation.

@43081j
Copy link
Contributor

43081j commented Sep 30, 2024

It may also be worth explaining that some simple use cases don't need a package

Maybe we list "native" as an alternative and give some examples?

@43081j 43081j merged commit be8aadb into es-tooling:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bodyparser -> milliparsec
4 participants