Configurable "Find next"/"Find previous" behavior #3570
Merged
+38
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranif
requested changes
Jan 10, 2025
UffeJakobsen
force-pushed
the
master_uj_find_next_prev_selection_logic
branch
2 times, most recently
from
bb1169c to
7bbf704
Compare
"Find next"/"Find previous" behavior can now be configured "Find next as caret"/"Find previous at caret" behavior is unchanged "Find next"/"Find previous" actions: Existing behavior: selected text is used as new search text - (like "Find next as caret"/"Find previous at caret") New optional behavior: selected text is ignored - existing search text is used The new optional behavior also solves problem reported in issue eranif#3568 Regex find patterns are delete by selected text upon repeating Find next/Find previous
UffeJakobsen
force-pushed
the
master_uj_find_next_prev_selection_logic
branch
from
7bbf704 to
c48d7df
Compare
eranif
approved these changes
Jan 11, 2025
|
Thanks 👍 :-) |
|
If this PR fixes your issue, please close it 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Configurable "Find next"/"Find previous" behavior
"Find next"/"Find previous" behavior can now be configured
"Find next as caret"/"Find previous at caret" behavior is unchanged
"Find next"/"Find previous" actions:
Existing behavior: selected text is used as new search text - (like "Find next as caret"/"Find previous at caret")
New optional behavior: selected text is ignored - existing search text is used
The new optional behavior also solves problem reported in issue #3568:
Where regex find patterns are deleted by selected text upon repeating Find next/Find previous