Check for looping symlinks when building PHP projects #3401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3396
Finally located the issue for the IDE getting stuck on some project, this has brought so much pain over the last few years 😭
(I had gotten used to removing the vendor folder before starting CodeLite, or loading a different project and adding search paths)
The solution here is to resolve each folder before scanning it and then keeping track of the resolved paths, if we encounter a real path we have already seen previously we do not visit the symlink.
The alternative could be to simply not follow symlinks, but this feels like a better solution as it supports cases where the symlinks are relevant, but avoids cases where they are self nesting.