fix: handle detached nodes for accessible descriptions #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026
Updates the
computeAccessibleDescription()
method to handle computation of an accessible description for an element that has not been added to the document.In this fix I have opted to use the
querySelector()
approach, using a polyfill ofCSS.escape()
to handle special characters in the element'sid
(e.g. seeReact.useId()
). There may be other valid approaches that are less involved and more performant.The fix is applied to the
queryIdRefs()
utility, and so also impacts other usage such asaria-owns
andaria-labelledby
evaluation.