Save proofs #187
Merged
Save proofs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Multiple theorems in one file. - Finish justification mappings. - Recreate theorems. - Optionally recompute theorems and cache, recompute but not cache, or use cache (sbt tasks?). - Evaluate.
… including some from the library with imports. theorems get fully reconstructed. Now, integrate.
… Can now create a high level THM directly from a kernel theorem. Left to do: Apply that to proof files. Options to run with cache, without cache without creating it and without cache and create it. Need to detect changes in statements. POssibly, do hashconsing before storing
…whether serialization is activated to constructors? How to construct theorems in a good order?
…y successful. Running Recursion.scala (i.e. everything) takes around 19s instead of 24s
|
| @@ -30,6 +30,8 @@ abstract class Library extends lisa.prooflib.WithTheorems with lisa.prooflib.Pro | |||
|
|
|||
| var last: Option[JUSTIFICATION] = None | |||
|
|
|||
| var _withCache: Boolean = false | |||
There was a problem hiding this comment.
We should probably wrap this up in a settings interface. Eg: Settings.runWithCache(true) in the relevant file
There was a problem hiding this comment.
Not in this PR necessarily, but going forward.
There was a problem hiding this comment.
Good idea, I'll do that somewhat soon, probably in the next PR
| @@ -19,7 +19,7 @@ private[settheory] trait SetTheoryZAxioms extends SetTheoryDefinitions { | |||
| * | |||
| * `() |- (x = y) ⇔ ∀ z. z ∈ x ⇔ z ∈ y` | |||
| */ | |||
| final val extensionalityAxiom: this.AXIOM = Axiom("extensionalityAxiom", forall(z, in(z, x) <=> in(z, y)) <=> (x === y)) | |||
| final val extensionalityAxiom: this.AXIOM = Axiom(forall(z, in(z, x) <=> in(z, y)) <=> (x === y)) | |||
There was a problem hiding this comment.
Suggested change
| final val extensionalityAxiom: this.AXIOM = Axiom(forall(z, in(z, x) <=> in(z, y)) <=> (x === y)) | |
| final val extensionalityAxiom: AXIOM = Axiom(forall(z, in(z, x) <=> in(z, y)) <=> (x === y)) |
The type annotations in this file are slightly inconsistent, with just this one being different afaict
sankalpgambhir
approved these changes
Nov 20, 2023
| inline def rightSubstIff: Byte = 26 | ||
| inline def instSchema: Byte = 27 | ||
| inline def scSubproof: Byte = 28 | ||
| inline def sorry: Byte = 29 |
There was a problem hiding this comment.
Wouldn't it be better to have a toByte with pattern matching? That way we have pattern match exhaustivity checking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool to export proofs of theorems to binary files and back.