Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6084 - system doesnt allow select ambiguous monomers from the library except r while modifying nucleotides from sequence in rna builder #6343

Conversation

tanas80
Copy link
Collaborator

@tanas80 tanas80 commented Jan 22, 2025

How the feature works? / How did you fix the issue?

Clicking Update or Cancel in RNA Builder turns off sequence edit mode. RNA Builder handles keyDown events, Cancel on Escape, and Update on Enter.

Fix #6084

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Fix resetRnaBuilderAfterSequenceUpdate adding turnOffEditMode;
Fix SequenceItemContextMenu consts with enum.
Fix Editor.events.selectTool, .rightClickSequence using single arguments only.
Fix npm scripts adding test:types, use in prepush.
Fix editorEvent adding typing, adding keydown event.
Fix OpenOptions interactivity visuals.
Fix snapshots for OpenOptions interactivity visuals.
@NataliaLoginova NataliaLoginova merged commit c5c7387 into master Jan 22, 2025
11 checks passed
@NataliaLoginova NataliaLoginova deleted the 6084-2-system-doesnt-allow-select-ambiguous-monomers-from-the-library branch January 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants