Allow postprocessing binary/script post download #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ep1cman
reviewed
Jan 6, 2025
| The binary / executable script receives a first argument with the storage location for the downloaded video. You can easily mount a script from a local filesystem to the container: | ||
|
|
||
| ```bash | ||
| rm -r /tmp/unifi ; docker rmi ghcr.io/ep1cman/unifi-protect-backup ; poetry build && docker buildx build . -t ghcr.io/ep1cman/unifi-protect-backup ; |
There was a problem hiding this comment.
rebuilding the container seems excessive for the readme
| @@ -93,7 +103,7 @@ async def start(self): | |||
| except Exception as e: | |||
| self.logger.error(f"Unexpected exception occurred, abandoning event {event.id}:", exc_info=e) | |||
|
|
|||
| async def _upload_video(self, video: bytes, destination: pathlib.Path, rclone_args: str): | |||
| async def _upload_video(self, video: bytes, destination: pathlib.Path, rclone_args: str, postprocess_binary: str): | |||
There was a problem hiding this comment.
why is this passed into here and never used?
| @@ -103,6 +113,7 @@ async def _upload_video(self, video: bytes, destination: pathlib.Path, rclone_ar | |||
| video (bytes): The data to be written to the file | |||
| destination (pathlib.Path): Where rclone should write the file | |||
| rclone_args (str): Optional extra arguments to pass to `rclone` | |||
| postprocess_binary (str): Optional extra path to postprocessing binary | |||
| @@ -82,9 +85,16 @@ async def start(self): | |||
| self.logger.debug(f" Destination: {destination}") | |||
|
|
|||
| try: | |||
| await self._upload_video(video, destination, self._rclone_args) | |||
| await self._upload_video(video, destination, self._rclone_args, self._postprocess_binary) | |||
There was a problem hiding this comment.
why is this passed into here and never used?
|
|
||
| # Postprocess | ||
| if self._postprocess_binary: | ||
| returncode_postprocess, stdout_postprocess, stderr_postprocess = await run_command(f'"{self._postprocess_binary}" "{destination}"') |
There was a problem hiding this comment.
I feel that the exit codes here should have some signficance to how the script proceeds.
Maybe:
0 = OK
1 = Error, raise exception
2 = Error, but ok to proceed with upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR (next to #179)
This change allows for providing a postprocess binary/script, to execute custom logic post downloading a video.
In my specific case, after downloading motion detection, I want to run a script to detect if there are animals in the video (wildlife). If not: discard. If animals: upload to Youtube (wildlife channel).
Added readme, etc. etc. & relatively verbose logging of stdout and stderr if the postprocessing binary path is specified.
P.S. reason for me adding this:
https://github.com/WietseWind/Unifi-Wildlife-Detection