-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable step_image_registries for tasks #78
Conversation
This commit removes the `step_image_registries` policies from the `redhat-trusted-tasks` policy config. Currently, the Task definitions we want to validate don't conform to those policies. This will be re-enabled in EC-374. Signed-off-by: Luiz Carvalho <[email protected]>
This commit uses v3 of gomplate instead of v4. v3 is still actively maintained (latest release was last week). v4 still has pre-releases. The latest v4 release has `replace` directives in go.mod. This causes go to refuse to install: > The go.mod file for the module providing named packages contains one > or more replace directives. It must not contain directives that would > cause it to be interpreted differently than if it were the main > module. Signed-off-by: Luiz Carvalho <[email protected]>
@@ -52,4 +52,4 @@ ci: update-needed-check yaml-parse-check | |||
|
|||
# See https://docs.gomplate.ca/installing/ for other installation methods | |||
install-gomplate: | |||
go install github.com/hairyhenderson/gomplate/v4/cmd/gomplate@latest | |||
go install github.com/hairyhenderson/gomplate/v3/cmd/gomplate@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but why do we need to downgrade gomplate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the question about gomplate
, this seems pretty straightforward, LGTM
I added an explanation in the message for the second commit. I'll share it here for convenience:
|
@lcarva Thanks, that makes sense! |
This commit removes the
step_image_registries
policies from theredhat-trusted-tasks
policy config. Currently, the Task definitions we want to validate don't conform to those policies. This will be re-enabled in EC-374.