Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable step_image_registries for tasks #78

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

lcarva
Copy link
Member

@lcarva lcarva commented Jan 29, 2024

This commit removes the step_image_registries policies from the redhat-trusted-tasks policy config. Currently, the Task definitions we want to validate don't conform to those policies. This will be re-enabled in EC-374.

This commit removes the `step_image_registries` policies from the
`redhat-trusted-tasks` policy config. Currently, the Task definitions we
want to validate don't conform to those policies. This will be
re-enabled in EC-374.

Signed-off-by: Luiz Carvalho <[email protected]>
This commit uses v3 of gomplate instead of v4. v3 is still actively
maintained (latest release was last week). v4 still has pre-releases.
The latest v4 release has `replace` directives in go.mod. This causes go
to refuse to install:

> The go.mod file for the module providing named packages contains one
> or more replace directives. It must not contain directives that would
> cause it to be interpreted differently than if it were the main
> module.

Signed-off-by: Luiz Carvalho <[email protected]>
@@ -52,4 +52,4 @@ ci: update-needed-check yaml-parse-check

# See https://docs.gomplate.ca/installing/ for other installation methods
install-gomplate:
go install github.com/hairyhenderson/gomplate/v4/cmd/gomplate@latest
go install github.com/hairyhenderson/gomplate/v3/cmd/gomplate@latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but why do we need to downgrade gomplate?

Copy link

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the question about gomplate, this seems pretty straightforward, LGTM

@lcarva
Copy link
Member Author

lcarva commented Jan 29, 2024

Besides the question about gomplate, this seems pretty straightforward, LGTM

I added an explanation in the message for the second commit. I'll share it here for convenience:

Use stable release of gomplate

This commit uses v3 of gomplate instead of v4. v3 is still actively
maintained (latest release was last week). v4 still has pre-releases.
The latest v4 release has replace directives in go.mod. This causes go
to refuse to install:

The go.mod file for the module providing named packages contains one
or more replace directives. It must not contain directives that would
cause it to be interpreted differently than if it were the main
module.

@lcarva lcarva merged commit 7004ba9 into enterprise-contract:main Jan 29, 2024
3 checks passed
@lcarva lcarva deleted the EC-359 branch January 29, 2024 21:27
@mbestavros
Copy link

@lcarva Thanks, that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants