Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Builders for the In-Memory Table #12046

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jan 13, 2025

Pull Request Description

  • Convert Builder to be an interface rather than an abstract base class.
    • Add methods from TypedBuilder into the base interface: accepts, canRetypeTo, retypeTo.
  • Remove fillUpToSize and replace with a method in the Enso code (also throws Enso panic not a Java exception).
  • Rename retypeToMixed to copyDataTo allowing copying the data to an Object array. All builders now support.
  • Rename TypedBuilderImpl to TypedBuilder.
  • retypeTo always throws UnsupportedOperationException if not supported.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant