Refactor Builders for the In-Memory Table #12046
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Builder
to be an interface rather than an abstract base class.TypedBuilder
into the base interface:accepts
,canRetypeTo
,retypeTo
.fillUpToSize
and replace with a method in the Enso code (also throws Enso panic not a Java exception).retypeToMixed
tocopyDataTo
allowing copying the data to an Object array. All builders now support.TypedBuilderImpl
toTypedBuilder
.retypeTo
always throwsUnsupportedOperationException
if not supported.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.