Reducing helper methods in Standard.Base.Meta
#12031
Conversation
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
hubertp and
Akirathan
as code owners
| check x y = Meta.is_a x y |
There was a problem hiding this comment.
Calling Meta.is_a doesn't really work with EnsoMultiValue - another problem to keep in mind for
There was a problem hiding this comment.
What do you mean by "doesn't work"? Does it return wrong results, or raise an error?
There was a problem hiding this comment.
It extracts the first value from EnsoMultiValue and dispatches to it, I think.
| @@ -491,7 +388,7 @@ type Language | |||
| Arguments: | |||
| - value: The value to check. | |||
| is_atom_constructor : Any -> Boolean | |||
| is_atom_constructor value = @Builtin_Method "Meta.is_atom_constructor" | |||
| is_atom_constructor value = @Tail_Call Meta_Helpers.is_atom_constructor_builtin value | |||
There was a problem hiding this comment.
This could be rewritten as Meta.meta value . is_a Meta.Atom, but I guess that's too complicated? Or isn't it?
There was a problem hiding this comment.
No, is_atom_constructor doesn't seem to have any usages, but for example is_atom is tested:
|
|
||
| ## PRIVATE | ||
| instrumentor_builtin op args = @Builtin_Method "Meta.instrumentor_builtin" | ||
| get_qualified_type_name value = @Tail_Call Meta_Helpers.get_qualified_type_name_builtin value |
There was a problem hiding this comment.
This should be (Meta.meta value : Meta.Type) . qualified_name. There is quite a few usages, but I can rewrite them if we think it is a good idea?
There was a problem hiding this comment.
Given there are so many usages I think it may be good to have one common method that encapsulates this common pattern instead of reproducing the 'assert type + get qualified_name' in every place.
| Function anyFun = symbol.getScope().lookupMethodDefinition(any, symbol.getName()); | ||
| if (anyFun != null) { | ||
| function = anyFun; | ||
| if (selfTpe.getDefinitionScope().getAssociatedType() != selfTpe) { |
There was a problem hiding this comment.
Refines
to give precedence to Meta.is_a over Any.is_a self, just like it used to be done when Meta.is_a was a builtin.
There was a problem hiding this comment.
- separated into its own Prefer module methods over
Anyinstance ones #12048
| Any.check_is self t = "got to Any for "+self.to_text+" and "+t.to_text | ||
| dispatch a = Type_With_Check.check_is a |
There was a problem hiding this comment.
- this case remains the same as specified by Always call instance methods on Any #7033
JaroslavTulach
added
the
CI: Clean build required
JaroslavTulach
changed the title
Standard.Base.Meta
Pull Request Description
Let's reduce the amount of code inside of
Meta.ensoin preparation of #5226.Important Notes
Meta.is_afrom a builtin into regular method had its issues - solved by Prefer module methods overAnyinstance ones #12048Another set of provides is related to making
Meta.Type,Meta.Atom, etc. constructors private. Turned out the whole type was considered private and for exampleMeta.Type.findwas no longer accessible.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,