Remove listGroups while building categories #11988
Open
+263
−681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
added
g-dashboard
CI: No changelog needed
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
5 tasks
# Conflicts: # app/gui/src/dashboard/hooks/backendHooks.tsx # app/gui/src/dashboard/layouts/AssetsTable.tsx
|
Re-requesting CR as this PR changed after the latest code review |
Previosly we were wrongly relying on the presence of the file. That way, a bash script meant that NI integration was wrongly used. This change uses Tika, but it has already been present in other subprojects so no additional dependency shall be added. Follow up on #11880.
MrFlashAccount
requested review from
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
| @@ -4495,10 +4495,12 @@ lazy val `runtime-version-manager` = project | |||
| libraryDependencies ++= Seq( | |||
| "com.typesafe.scala-logging" %% "scala-logging" % scalaLoggingVersion, | |||
| "org.apache.commons" % "commons-compress" % commonsCompressVersion, | |||
| "org.apache.tika" % "tika-core" % tikaVersion, | |||
There was a problem hiding this comment.
why is this part of the changeset?
There was a problem hiding this comment.
Shouldn't be. I think it's a bad merge or something. Will fix, thank you!
somebody1234
approved these changes
Jan 13, 2025
JaroslavTulach
requested changes
Jan 14, 2025
| @@ -0,0 +1,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
No changes to project-manager in this PR please.
There was a problem hiding this comment.
Yeah, this was a bad merge or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds new field called
groupson the User object to avoid fetching the usergroups list to get the names of the groups.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.