Merge branch 'develop' into wip/sb/refactor-localstorage

enso-org · Dec 11, 2024 · 7cce37e · 7cce37e
2 parents 0165dda + 9e00b9d
commit 7cce37e
Show file tree

Hide file tree

Showing 849 changed files with 19,786 additions and 9,738 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -31,8 +31,8 @@ tsconfig.json
 
 # GUI/Dashboard
 /app @Frizi @farmaazon @vitvakatu @kazcw @AdRiley @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
-/app/gui/e2e/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
-/app/gui/e2e/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley 
+/app/gui/integration-test/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
+/app/gui/integration-test/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley 
 /app/gui/src/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
 /app/gui/src/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley 
 /app/ide-desktop/ @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
@@ -59,5 +59,9 @@ tsconfig.json
 /test/ @jdunkerley @radeusgd @GregoryTravis @AdRiley @marthasharkey
 /tools/http-test-helper/ @radeusgd @jdunkerley @GregoryTravis @AdRiley @marthasharkey
 
+# Licenses
+/distribution/engine/
+/tools/legal-review/
+
 # The default project template is owned by the libraries team
 /lib/scala/pkg/src/main/resources/default/src/ @radeusgd @jdunkerley @GregoryTravis @AdRiley @marthasharkey
diff --git a/.github/workflows/engine-nightly.yml b/.github/workflows/engine-nightly.yml
@@ -270,7 +270,7 @@ jobs:
       - run: ./run backend test jvm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Engine Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -327,7 +327,7 @@ jobs:
       - run: ./run backend test jvm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Engine Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -382,7 +382,7 @@ jobs:
       - run: ./run backend test jvm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Engine Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -438,7 +438,7 @@ jobs:
       - run: ./run backend test jvm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Engine Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -494,7 +494,7 @@ jobs:
       - run: ./run backend test jvm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Engine Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -553,7 +553,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -613,7 +613,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -671,7 +671,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -730,7 +730,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -789,7 +789,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:

diff --git a/.github/workflows/extra-nightly-tests.yml b/.github/workflows/extra-nightly-tests.yml
@@ -55,7 +55,7 @@ jobs:
           ENSO_SNOWFLAKE_USER: ${{ secrets.ENSO_SNOWFLAKE_USER }}
           ENSO_SNOWFLAKE_WAREHOUSE: ${{ secrets.ENSO_SNOWFLAKE_WAREHOUSE }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Extra Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -77,6 +77,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     env:
       GRAAL_EDITION: GraalVM CE
+      REPORT_ALL_TESTS: "1"
     permissions:
       checks: write
   enso-build-ci-gen-job-standard-library-tests-graal-vm-ce-linux-amd64:
@@ -118,7 +119,7 @@ jobs:
           ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
           ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - if: (success() || failure()) && github.event.pull_request.head.repo.full_name == github.repository
+      - if: (success() || failure()) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
         name: Standard Library Test Reporter
         uses: dorny/test-reporter@v1
         with:
@@ -140,6 +141,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     env:
       GRAAL_EDITION: GraalVM CE
+      REPORT_ALL_TESTS: "1"
     permissions:
       checks: write
 env:

diff --git a/.github/workflows/gui-checks.yml b/.github/workflows/gui-checks.yml
@@ -70,7 +70,7 @@ jobs:
       - name: 🧪 Unit Tests
         id: unit-tests
         continue-on-error: true
-        run: pnpm run ci:test
+        run: pnpm run ci:unit-test
 
       - name: 📝 Annotate Code Linting Results
         if: always()
@@ -146,7 +146,7 @@ jobs:
 
       - name: 🎭 Playwright Tests
         working-directory: app/gui
-        run: pnpm run e2e --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
+        run: pnpm run test:integration --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
 
       - name: ⬆️ Upload blob report to GitHub Actions Artifacts
         if: ${{ !cancelled() }}

diff --git a/.github/workflows/gui-pull-request.yml b/.github/workflows/gui-pull-request.yml
@@ -72,24 +72,21 @@ jobs:
     if: ${{ needs.changed-files.outputs.any_changed == 'true' }}
     secrets: inherit
 
-  print-checks-result:
-    name: 🤷 Print checks result
-    runs-on: ubuntu-latest
-    needs: [checks, storybook]
-    if: always()
-    steps:
-      - name: Print checks result
-        run: |
-          echo "Checks: ${{ needs.checks.result }}"
-          echo "Storybook: ${{ needs.storybook.result }}"
-
   # This job is used to report success if the needed jobs were successful.
   # This is a workaround to make optional jobs required if they run
   report-success:
     name: GUI Checks Success or Skipped
     runs-on: ubuntu-latest
     needs: [checks, storybook]
-    if: always() && (needs.checks.result == 'skipped' && needs.storybook.result == 'skipped') || (needs.checks.result == 'success' && needs.storybook.result == 'success')
+    if: always()
     steps:
       - name: Report success
-        run: echo "Success!"
+        run: |
+          echo "Checks: ${{ needs.checks.result }}"
+          echo "Storybook: ${{ needs.storybook.result }}"
+
+          if [[ "${{ needs.checks.result }}" == "failure" || "${{ needs.storybook.result }}" == "failure" ]]; then
+            exit 1
+          fi
+
+          echo "Success!"
diff --git a/.github/workflows/gui.yml b/.github/workflows/gui.yml
@@ -14,6 +14,9 @@ on:
         required: false
         type: boolean
         default: false
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }}
 jobs:
   enso-build-ci-gen-job-build-backend-linux-amd64:
     name: Build Backend (linux, amd64)
@@ -143,18 +146,6 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  enso-build-ci-gen-job-cancel-workflow-linux-amd64:
-    name: Cancel Previous Runs
-    if: github.ref != 'refs/heads/develop'
-    runs-on:
-      - ubuntu-latest
-    steps:
-      - name: Cancel Previous Runs
-        uses: styfle/[email protected]
-        with:
-          access_token: ${{ github.token }}
-    permissions:
-      actions: write
   enso-build-ci-gen-job-gui-build-linux-amd64:
     name: GUI build (linux, amd64)
     runs-on:
@@ -372,6 +363,13 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - if: failure()
+        name: Upload Test Traces
+        uses: actions/upload-artifact@v4
+        with:
+          compression-level: 0
+          name: test-traces-linux-amd64
+          path: app/ide-desktop/client/test-traces
       - run: rm $HOME/.enso/credentials
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -444,6 +442,13 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - if: failure()
+        name: Upload Test Traces
+        uses: actions/upload-artifact@v4
+        with:
+          compression-level: 0
+          name: test-traces-macos-amd64
+          path: app/ide-desktop/client/test-traces
       - run: rm $HOME/.enso/credentials
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -512,7 +517,13 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        continue-on-error: true
+      - if: failure()
+        name: Upload Test Traces
+        uses: actions/upload-artifact@v4
+        with:
+          compression-level: 0
+          name: test-traces-windows-amd64
+          path: app/ide-desktop/client/test-traces
       - run: rm $HOME/.enso/credentials
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -5,13 +5,23 @@ name: Nightly Release
 on:
   schedule:
     - cron: 0 2 * * *
-  workflow_dispatch: {}
+  workflow_dispatch:
+    inputs:
+      ydoc:
+        description: What kind of Ydoc image to build.
+        required: false
+        type: choice
+        default: nodejs
+        options:
+          - nodejs
+          - polyglot
 jobs:
   promote-nightly:
     name: Promote nightly
     uses: ./.github/workflows/promote.yml
     with:
       designator: nightly
+      ydoc: ${{ inputs.ydoc || 'nodejs' }}
     secrets: inherit
 env:
   ENSO_BUILD_SKIP_VERSION_CHECK: "true"
diff --git a/.github/workflows/promote.yml b/.github/workflows/promote.yml
@@ -14,12 +14,25 @@ on:
           - patch
           - rc
           - nightly
+      ydoc:
+        description: What kind of Ydoc image to build.
+        required: false
+        type: choice
+        default: nodejs
+        options:
+          - nodejs
+          - polyglot
   workflow_call:
     inputs:
       designator:
         description: What kind of release should be promoted.
         required: true
         type: string
+      ydoc:
+        description: What kind of Ydoc image to build.
+        required: false
+        type: string
+        default: nodejs
 jobs:
   enso-build-ci-gen-promote-release-job-linux-amd64:
     name: Promote release (linux, amd64)
@@ -76,6 +89,7 @@ jobs:
     uses: ./.github/workflows/release.yml
     with:
       version: ${{ needs.enso-build-ci-gen-promote-release-job-linux-amd64.outputs.ENSO_VERSION }}
+      ydoc: ${{ inputs.ydoc }}
     secrets: inherit
 env:
   ENSO_BUILD_SKIP_VERSION_CHECK: "true"