-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: clean up naming to be consistent with snake_case #99
Open
schicho
wants to merge
18
commits into
emukidid:master
Choose a base branch
from
schicho:naming-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, if you feel like doing this to the entire codebase I don't mind. |
…plicate color definitions
That's what I did. You may take a look now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the code to be consistent with
snake_case
everywhere. Before there was a mixture of diverse naming styles.Due to modifying almost every file, the line count has gotten quite large. I have split up the changes per .c and corresponding header file into individual commits, to maybe make it a bit more easy to view the changes. Every commit is buildable.
Changes:
I have not changed the code in md5, sha1 and crc32 as these are libraries, which have been written like that by others years ago and is not core cleanrip code. Would you also handle it that way?
If there are any objections to these changes or need for discussion, let me know.