Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): Update rule-sql-syntax.md #2590

Open
wants to merge 3 commits into
base: release-5.5
Choose a base branch
from

Conversation

Meggielqk
Copy link
Collaborator

No description provided.

@Meggielqk Meggielqk added this to the e5.5.0 milestone Jul 30, 2024
@Meggielqk Meggielqk requested a review from jinrm July 30, 2024 09:26
Copy link
Member

@jinrm jinrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“The Pulsar Sink supports synchronous write modes, allowing for a flexible balance between latency and throughput according to different scenarios.”
maybe it's better to delete "allowing for a flexible balance between latency and throughput according to different scenarios" since only sync mode is supported?

@Meggielqk
Copy link
Collaborator Author

“The Pulsar Sink supports synchronous write modes, allowing for a flexible balance between latency and throughput according to different scenarios.” maybe it's better to delete "allowing for a flexible balance between latency and throughput according to different scenarios" since only sync mode is supported?

No need to change the documentation. In EMQX 5.8, the asynchronous mode will be supported after th bug fix.

@Meggielqk Meggielqk changed the title fix(Pulsar integration): Remove "asynchronous" write mode fix(typo): Update rule-sql-syntax.md Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants