Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forward user's RTP header extensions in send_rtp/4 #184

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 15, 2025

This PR ensures that we don't accidentally forward non-negotiated RTP header extensions in RTP packet.

When playing with simulcast, it is very common that send_rtp/4 receives an RTP packet that contains extensions related to simulcast (e.g. RID). We should not forward them to the other side if they were not negotiated.

@mickel8 mickel8 requested a review from sgfn January 15, 2025 12:06
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (d74a937) to head (1a25130).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   88.03%   88.08%   +0.05%     
==========================================
  Files          47       47              
  Lines        2381     2384       +3     
==========================================
+ Hits         2096     2100       +4     
+ Misses        285      284       -1     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.94% <100.00%> (+0.20%) ⬆️
lib/ex_webrtc/peer_connection/configuration.ex 94.89% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74a937...1a25130. Read the comment docs.

@mickel8 mickel8 merged commit 1d09628 into master Jan 15, 2025
1 check failed
@mickel8 mickel8 deleted the fix-extensions branch January 15, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants