Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerConneciton.set_packet_loss #182

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add PeerConneciton.set_packet_loss #182

merged 1 commit into from
Jan 6, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 6, 2025

This PR adds an ability to set very simple packet loss for a peer connection.

While I haven't seen such function in any other WebRTC implementation, I found it useful for experimental and demo purposes where setting packet loss on a network interface might be too broad.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (2ef1582) to head (04be4ae).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/peer_connection.ex 0.00% 2 Missing ⚠️
lib/ex_webrtc/dtls_transport.ex 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   87.81%   88.09%   +0.28%     
==========================================
  Files          47       47              
  Lines        2371     2378       +7     
==========================================
+ Hits         2082     2095      +13     
+ Misses        289      283       -6     
Files with missing lines Coverage Δ
lib/ex_webrtc/dtls_transport.ex 84.67% <92.30%> (+0.58%) ⬆️
lib/ex_webrtc/peer_connection.ex 85.88% <0.00%> (+0.33%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef1582...04be4ae. Read the comment docs.

@mickel8 mickel8 merged commit 564e0f3 into master Jan 6, 2025
1 check passed
@mickel8 mickel8 deleted the packet-loss branch January 6, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant