-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quote_style option to csv IO functions #1049
Add quote_style option to csv IO functions #1049
Conversation
Thanks, this seems useful! Rust code looks good at a glance. And yes we'll need a test or two (on the Elixir side). |
Tests added |
Keyword.validate!(opts, | ||
header: true, | ||
delimiter: ",", | ||
quote_style: :necessary, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need documentation on the supported values for this function and we are good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, let me know if there's any additional places needed
@jdbarillas thank you! :D |
Implements the QuoteStyle options for CsvWriter into
to_csv
anddump_csv
(with:necessary
as default)New behavior:
TO DO:
This is my first experience with Rust so any feedback would be appreciated.