add H to list of sigil characters #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorolinasc
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
This is provided by Phoenix.Component rather than by the standard library, but they're used several times in freshly generated Phoenix projects beginning in version 1.7, and without adding this the font locking quickly goes off the rails in files where
~H"""is used. although it would be great to have true HTML font locking for dealing with embedded EEx inside heredocs, this was a one-character fix sufficient for my immediate needs, so i figured i would start with this hoping others would find it useful, and then maybe take a deeper look at font locking improvements that would require heavier changes later on.