Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ~H to recognized sigils #501

Closed
mus0u opened this issue May 17, 2023 · 1 comment · Fixed by #502
Closed

add ~H to recognized sigils #501

mus0u opened this issue May 17, 2023 · 1 comment · Fixed by #502
Labels
enhancement good first issue New to contributing to emacs-related F/OSS? This may be for you. help wanted

Comments

@mus0u
Copy link
Contributor

mus0u commented May 17, 2023

This is provided by Phoenix.Component rather than by the standard library, but they're used several times in freshly generated Phoenix projects beginning in version 1.7, and without adding this the font locking quickly goes off the rails in files where ~H""" is used. although it would be great to have true HTML font locking for dealing with embedded EEx inside heredocs, this was a one-character fix sufficient for my immediate needs, so i figured i would start with this hoping others would find it useful, and then maybe take a deeper look at font locking improvements that would require heavier changes later on.

@victorolinasc victorolinasc added enhancement help wanted good first issue New to contributing to emacs-related F/OSS? This may be for you. labels Jun 12, 2023
@victorolinasc
Copy link
Contributor

This is similar to #474 and is ALSO affected gravely by #473

A common theme is that Elixir is a macroful language and for a regex-driven mode it might be a bit though to add customizable extra macros.

In theory, if we add ~H we are saying we are open for other sigils/macros. The thing is that any library or user code might have sigils/macros and so on. Phoenix is not special in this regard and although I think we should add it for now, we must decide upon some way of customizing it so that it accepts other possible sigils and macros and we don't clutter the mode here.

A PR adding direct support is appreciated (though Elixir is starting to allow multi letter sigils) but we should, nonetheless, think of how to support customizable macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue New to contributing to emacs-related F/OSS? This may be for you. help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants