Fix: restartPolicy and limits

[lvarin]

• If restart_policy but restartPolicy does not, uses the former to populate the later
• If limits is empty, uses requests so limits == requests

Summary by Sourcery

Fix issues with task specification by ensuring 'restartPolicy' is set from 'restart_policy' when missing, and aligning 'limits' with 'requests' in container resources when 'limits' is not specified.

Bug Fixes:

• Ensure 'restartPolicy' is populated from 'restart_policy' if the former is missing.
• Set 'limits' to equal 'requests' in container resources if 'limits' is empty and 'requests' is not.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses two issues in the taskmaster.py file: it adds logic to use 'restart_policy' to populate 'restartPolicy' if the latter is missing, and it sets resource limits equal to requests when limits are not specified.

File-Level Changes

Change	Details	Files
Add fallback for missing 'restartPolicy'	Check if 'restartPolicy' is missing from the spec Use 'restart_policy' to populate 'restartPolicy' if available	src/tesk_core/taskmaster.py
Set resource limits equal to requests when limits are not specified	Iterate through containers in the spec Check if limits are None and requests are not None Set limits equal to requests when limits are missing	src/tesk_core/taskmaster.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @lvarin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding brief comments to explain the purpose of each change. This would help future maintainers understand the rationale behind these modifications.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[trispera]

LGTM