Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add missing arg in config map update script #66

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Aug 6, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

Fix missing --arg parameter in the update-config-map.sh script to correctly update the configuration map with the MONGO_HOST value.

Bug Fixes:

  • Add missing --arg parameter for MONGO_HOST in update-config-map.sh script to ensure proper configuration.

Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

Reviewer's Guide by Sourcery

This pull request addresses a bug by adding a missing --arg parameter to the yq command in the update-config-map.sh script. This ensures that the MongoDB host is correctly included in the configuration update.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvarin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The code change looks good, but please ensure you complete the PR checklist and provide more context in the description about the specific issue this fix addresses.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@lvarin lvarin force-pushed the fix_update-config-map branch from 41e301f to 5218e91 Compare August 6, 2024 10:30
@uniqueg uniqueg changed the title fix: Add missing --arg in script to update config map build: add missing arg in config map update script Aug 6, 2024
@lvarin lvarin merged commit 899eec8 into dev Aug 6, 2024
5 checks passed
@lvarin lvarin deleted the fix_update-config-map branch August 6, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants