-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace Travis CI with GH Actions #64
Conversation
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Reviewer's Guide by SourceryThis pull request replaces Travis CI with GitHub Actions for continuous integration. It introduces new GitHub Actions workflows for building and publishing Docker images, running lint checks, and executing unit tests. Additionally, it includes a comprehensive test suite for the DRS Filer endpoints. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psankhe28 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Remove unused matrix variable. (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟡 Testing: 12 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Seems there is an issue with the workflow - apparently it tries to run Python 3.1 (probably should be 3.10). Btw, Py 3.7 is end-of-life, and Py 3.8 is end-of-life in October this year, so I think you can remove those. Moreover, this is a standalone service, not a library, so we won't need to support multiple Python versions. So I think it'd be best to only support (and test) the latest stable version, which is 3.11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address all open comments, including the Sourcery ones 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, last very minor changes :)
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny thing left :)
Signed-off-by: Prati28 <[email protected]>
Description
Added GitHub actions for all drs-filer endpoints.
Fixes # (issue)
#58
Type of change
Please delete options that are not relevant.
Checklist:
Summary by Sourcery
This pull request replaces Travis CI with GitHub Actions for continuous integration. It introduces new workflows for building Docker images, running linting and unit tests, and testing API endpoints. Additionally, comprehensive tests for DRS-Filer endpoints have been added.