removed check for session in captcha request. sytest 11register.pl do…

…esnt provide this and fails
element-hq · Dec 14, 2024 · 0cb78f8 · 0cb78f8
1 parent 2701a2a
commit 0cb78f8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/synapse/handlers/ui_auth/checkers.py b/synapse/handlers/ui_auth/checkers.py
@@ -115,12 +115,6 @@ async def check_auth(self, authdict: dict, clientip: str) -> Any:
             raise LoginError(
                 400, "Captcha response is required", errcode=Codes.CAPTCHA_NEEDED
             )
-        try:
-            _ = authdict["session"]
-        except KeyError:
-            # Client tried to provide captcha but didn't give the session ID:
-            # bad request.
-            raise LoginError(400, "Missing UIA session", Codes.MISSING_PARAM)
 
         logger.debug("Submitting recaptcha response %s", user_response)
 

diff --git a/tests/handlers/test_checkers.py b/tests/handlers/test_checkers.py
@@ -81,7 +81,7 @@ def test_check_missing_session(self: "TestRecaptchaAuthChecker") -> None:
 
         d = ensureDeferred(self.recaptcha_checker.check_auth(authdict, clientip))
         f = self.failureResultOf(d, LoginError)
-        self.assertEqual(f.value.errcode, Codes.MISSING_PARAM)
+        self.assertEqual(f.value.errcode, Codes.UNAUTHORIZED)
 
     def test_check_auth_missing_response(self: "TestRecaptchaAuthChecker") -> None:
         """Test that authentication fails when the user captcha response is missing."""