Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more flaky playwright tests #29007

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Fix more flaky playwright tests #29007

merged 9 commits into from
Jan 17, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 15, 2025

Fixes #27840
Fixes #28999
Fixes #28950
Fixes #27451

@t3chguy
Group systemic playwright flakes
7be2097 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix more flaky tests
029bd92 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added T-Task Tasks for the team like planning X-Run-All-Tests When applied to PRs, it'll run the full gamut of end-to-end tests on the PR labels Jan 15, 2025
@t3chguy t3chguy self-assigned this Jan 15, 2025
@t3chguy
Fix another flake
e387e3a 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
6af4c34 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
feb8494 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
delint
30b64ca 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix more flakes
2b4f66a 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy removed the X-Run-All-Tests When applied to PRs, it'll run the full gamut of end-to-end tests on the PR label Jan 15, 2025
@t3chguy
Iterate
b4805d0 
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
t3chguy commented Jan 15, 2025
View reviewed changes
playwright/e2e/settings/encryption-user-tab/recovery.spec.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webkit doesn't support clipboard permissions under Playwright

@t3chguy
Fix skip tests being wrong
95fce28 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review January 16, 2025 11:13
@t3chguy t3chguy requested review from a team as code owners January 16, 2025 11:13
@t3chguy t3chguy requested review from richvdh and dbkr January 16, 2025 11:13
andybalaam
andybalaam approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from a Crypto POV

@andybalaam andybalaam removed the request for review from richvdh January 17, 2025 11:06
@t3chguy t3chguy added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit e42ee72 Jan 17, 2025
39 checks passed
@t3chguy t3chguy deleted the t3chguy/playwright-flakes-15jan branch January 17, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR approved these changes

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
3 participants
@t3chguy @andybalaam @MidhunSureshR