Switch to TestContainers for manging services in Playwright #28860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/playwright-testcontainers Signed-off-by: Michael Telatynski <[email protected]> # Conflicts: # playwright/plugins/docker/index.ts # playwright/plugins/homeserver/synapse/index.ts # playwright/plugins/mailhog/index.ts # playwright/plugins/matrix-authentication-service/index.ts # playwright/plugins/postgres/index.ts # playwright/plugins/sliding-sync-proxy/index.ts
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
commented
Jan 6, 2025
| * @returns A copy of the object without any references to the original. | ||
| */ | ||
| export function deepCopy<T>(obj: T): T { | ||
| return JSON.parse(JSON.stringify(obj)); |
There was a problem hiding this comment.
playwright didn't like importing src/utils.ts so had to dupe this here
Signed-off-by: Michael Telatynski <[email protected]>
Base automatically changed from
t3chguy/prepare-playwright-testcontainers
to
develop
January 7, 2025 09:37
…to t3chguy/playwright-testcontainers # Conflicts: # playwright/e2e/app-loading/guest-registration.spec.ts # playwright/e2e/crypto/dehydration.spec.ts # playwright/e2e/forgot-password/forgot-password.spec.ts # playwright/e2e/login/soft_logout.spec.ts # playwright/e2e/oidc/index.ts # playwright/e2e/register/email.spec.ts # playwright/e2e/register/register.spec.ts # playwright/plugins/homeserver/index.ts # playwright/plugins/homeserver/synapse/index.ts # playwright/plugins/homeserver/synapse/templates/mas-oidc/homeserver.yaml # playwright/plugins/matrix-authentication-service/config.yaml # playwright/plugins/matrix-authentication-service/index.ts
florianduros
approved these changes
Jan 7, 2025
…to t3chguy/playwright-testcontainers # Conflicts: # yarn.lock
…s' into t3chguy/playwright-testcontainers
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #28876Requires #28880This PR ultimately simplifies things and gains support for more container runtimes but is not going to be pleasant to review. Trying to soften the blow with emphasising how nice it'll be to control/tweak services going forward:
Adding a synapse config option is now trivial and doesn't require duplicating a directory of Synapse configs with confusing placeholders:
Using a homeserver with smtp connection to mailhog:
Using a homeserver with consent required:
Spinning up arbitrary additional containers:
Improved logs access:
Uses docker internal networking for inter-container communication which simplifies configurations massively.
There is a small speed penalty for these benefits, but it is marginal and future work should offset it:
Before
After
Future work: