Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright: wait for the network listener on the postgres db #28808

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Playwright: wait for the network listener on the postgres db #28808

merged 1 commit into from
Dec 23, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 23, 2024

As commented. This was flaking when I was debugging it locally (MAS was failing to start because the database wasn't ready).

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr
Playwright: wait for the network listener on the postgres db
180d831 
As commented. This was flaking when I was debugging it locally
(MAS was failing to start because the database wasn't ready).
@dbkr dbkr added the T-Defect label Dec 23, 2024
@dbkr dbkr marked this pull request as ready for review December 23, 2024 18:06
@dbkr dbkr requested a review from a team as a code owner December 23, 2024 18:06
@dbkr dbkr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into develop with commit 7e1927d Dec 23, 2024
44 checks passed
@dbkr dbkr deleted the dbkr/postgres_wait_for_net_listener branch December 23, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @t3chguy