Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to en-US locale for date tests #28723

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Change to en-US locale for date tests #28723

merged 2 commits into from
Dec 11, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 11, 2024

As per comment. Fixes the tests.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr
Change to en-US locale for date tests
c94fb7e 
As per comment. Fixes the tests.
@dbkr dbkr added the T-Task Tasks for the team like planning label Dec 11, 2024
@dbkr dbkr marked this pull request as ready for review December 11, 2024 18:21
@dbkr dbkr requested a review from a team as a code owner December 11, 2024 18:21
richvdh
richvdh approved these changes Dec 11, 2024
View reviewed changes
test/unit-tests/utils/DateUtils-test.ts Outdated Show resolved Hide resolved
@dbkr @richvdh
Spell locale right
b0ba1ee 
Co-authored-by: Richard van der Hoff <[email protected]>
@dbkr dbkr enabled auto-merge December 11, 2024 18:27
@dbkr dbkr added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit a755e39 Dec 11, 2024
33 checks passed
@dbkr dbkr deleted the dbkr/rogue_date_commas branch December 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @richvdh