Move rust-sdk wasm artifact into bundles directory
#28624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Note this script isn't used for most deployments, its pretty much only used for app.element.io, staging.element.io, and even there it will not be used anymore soon once we switch to CFP.
t3chguy
reviewed
Dec 3, 2024
|
I wouldn't think so, but can you point me to how that stuff works, so I can check? |
|
@richvdh |
|
Yeah, so that only looks at bundles which contain a |
t3chguy
reviewed
Dec 5, 2024
|
abandoning this in favour of #28718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of matrix-org/matrix-rust-sdk-crypto-wasm#167, the wasm build of matrix-sdk-crypto is actually shipped as a
.wasmfile, rather than base64-ed into Javascript. Our current webpack config then dumps it into the top level of the build directory, which will be a problem on redeployment (specifically, if you try to fetch the wasm artifact for vN after vN+1 has been deployed, you'll get a 404 and sadness).So, we need to move the wasm artifact into the
bundlesdirectory. We also tweak thedeployscript slightly: it'll be fine as-is but touching the mtime might prevent confusion later.Fixes: #28632