Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force legacy crypto for loading tests #26954

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Feb 1, 2024

The loading-test.tsx only runs correctly on legacy crypto. They are running a mix of localStorage and indexeddb storage (partial mock of indexeddb through the all stack), and also they are running without crypto (by not loading libolm). The rust sdk doesn't work this way, it's using indexeddb to store things and cannot be disabled by not loading a lib.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner February 1, 2024 20:37
@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Feb 1, 2024
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting @richvdh from a private Matrix room:

loading-test.tsx are mostly some application-level tests that I wrote back in 2016, and they attempt to test some of the startup flows in EW (as the comment says, though it hasn't been updated when the file was renamed). I don't think they offer a huge amount of value, and what little value they do offer would be better done in playwright anyway. #26954 seems like a good stopgap.

So I agree - this change keeps these tests running as they were, but they don't provide enough value to try to port them to Rust, certainly not to gate our Element Web R release behind making them work with Rust.

@BillCarsonFr BillCarsonFr added this pull request to the merge queue Feb 2, 2024
Merged via the queue into develop with commit 92b3fb1 Feb 2, 2024
22 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/only_run_loading_tests_on_legacy branch February 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants