Add Jitsi SDK as a static resource and set up CI to update it on change #26622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Nov 21, 2023
t3chguy
reviewed
Nov 21, 2023
t3chguy
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently download https://meet.element.io/libs/external_api.min.js at build time. Since this file is unversioned, this has the potential to make our builds non-deterministic as they'd bundle whatever happened to be on the server when building. It also adds a tiny amount of latency into our builds.
This PR includes the Jitsi SDK as a static file in the repository and adds a weekly CI run to check for updates and open a PR when needed. The workflow heavily borrows from https://github.com/matrix-org/matrix-web-i18n/blob/main/.github/workflows/localazy_download.yaml.
This change is marked as an internal change (Task), so will not be included in the changelog.