Use only chokidar for watching and add more logging in copy-res.ts #26591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
changed the title
t3chguy
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #26593
We're currently using both cpx and chokidar for watching files in
copy-res.ts. This is suboptimal because:This pull request switches all watching in the script to use chokidar. This reduces the initial runtime of
yarn run ts-node scripts/copy-res.ts -v -wfrom 4.5s to 2.4s on my machine1. Additionally logging for the watcher setup is added in verbose mode.This change is marked as an internal change (Task), so will not be included in the changelog.
Footnotes
It's worth pointing out that most of the speed-up could also have been had by setting
directwatch: 1oncontribute.json. ↩