Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship OpenCoDE variant to Dockerhub #26399

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Ship OpenCoDE variant to Dockerhub #26399

merged 4 commits into from
Nov 6, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 18, 2023 •
edited by github-actions bot
Loading

Fixes https://github.com/vector-im/wat-internal/issues/13
Based on https://gitlab.souvap-univention.de/souvap/tooling/images/element-web/-/tree/main?ref_type=heads

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy
Ship OpenCoDE variant to Dockerhub
9537e5f 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 18, 2023
@t3chguy t3chguy marked this pull request as ready for review October 19, 2023 08:17
@t3chguy t3chguy requested review from a team as code owners October 19, 2023 08:17
@t3chguy
s/OpenCoDE/openDesk/
a14ff31 
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
dbkr reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay but is there scope for it to be commented anywhere? I'm still struggling to understand what's going on even with the context of the bug it's fixing.

@t3chguy
Add comment
8809e37 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from dbkr November 3, 2023 10:36
dbkr
dbkr approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@t3chguy t3chguy enabled auto-merge (squash) November 3, 2023 10:42
@t3chguy t3chguy merged commit 019a7cc into develop Nov 6, 2023
17 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/wat13 branch November 6, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR approved these changes

@dbkr dbkr dbkr approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @dbkr @MidhunSureshR