Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunset banners guiding users to install Element X when registering against a server with MAS. #7890

Merged
merged 3 commits into from
Jan 10, 2025

Set the final URL.

da14867
Select commit
Loading
Failed to load commit list.
Merged

Add sunset banners guiding users to install Element X when registering against a server with MAS. #7890

Set the final URL.
da14867
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

15.12% (+0.04%) compared to d8bcc18

View this Pull Request on Codecov

15.12% (+0.04%) compared to d8bcc18

Details

Codecov Report

Attention: Patch coverage is 48.40764% with 162 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (d8bcc18) to head (da14867).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...on/Test/UI/AuthenticationRegistrationUITests.swift 0.00% 25 Missing ⚠️
.../AuthenticationServerSelectionViewModelTests.swift 0.00% 25 Missing ⚠️
...nit/AuthenticationRegistrationViewModelTests.swift 0.00% 23 Missing ⚠️
...tor/AuthenticationServerSelectionCoordinator.swift 0.00% 22 Missing ⚠️
...inator/AuthenticationRegistrationCoordinator.swift 0.00% 17 Missing ⚠️
...Test/UI/AuthenticationServerSelectionUITests.swift 0.00% 12 Missing ⚠️
...stration/AuthenticationRegistrationViewModel.swift 33.33% 8 Missing ⚠️
...les/Authentication/AuthenticationCoordinator.swift 0.00% 7 Missing ⚠️
...s/Common/Sunset/SunsetOIDCRegistrationBanner.swift 81.25% 6 Missing ⚠️
...I/Modules/Common/Sunset/SunsetDownloadBanner.swift 87.80% 5 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7890      +/-   ##
===========================================
+ Coverage    15.08%   15.12%   +0.04%     
===========================================
  Files         1810     1812       +2     
  Lines       173591   173859     +268     
  Branches     67305    67389      +84     
===========================================
+ Hits         26185    26298     +113     
- Misses      147370   147523     +153     
- Partials        36       38       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov