Implement MSC3270: Symmetric megolm backup #6984
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not be used (let valere continue on the privatekey generation)
BillCarsonFr
force-pushed
the
feature/fga/msc_3270
branch
from
9d6ce4d to
07ec899
Compare
ElementBot
reviewed
Oct 7, 2022
| @@ -124,6 +131,7 @@ interface KeysBackupService { | |||
| */ | |||
| fun prepareKeysBackupVersion( | |||
There was a problem hiding this comment.
⚠️ Documentation of prepareKeysBackupVersion is outdated
| */ | ||
| val algorithm: String | ||
|
|
||
| /** | ||
| * algorithm-dependent data, for "m.megolm_backup.v1.curve25519-aes-sha2" see [org.matrix.android.sdk.internal.crypto.keysbackup.MegolmBackupAuthData]. | ||
| * algorithm-dependent data, for "m.megolm_backup.v1.curve25519-aes-sha2" * see [org.matrix.android.sdk.api.session.crypto.keysbackup.MegolmBackupCurve25519AuthData]. |
There was a problem hiding this comment.
⚠️ Line detected, which is longer than the defined maximum line length in the code style.
BillCarsonFr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Support for MSC3270 Symmetric megolm backup.
matrix-org/matrix-spec-proposals#3270
Notice that support is threre but not enabled. It can be enabled by changing the keysBackupService KeyBackupConfig
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist